[
https://issues.apache.org/jira/browse/THRIFT-3150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14553349#comment-14553349
]
Konstantin Shaposhnikov commented on THRIFT-3150:
-------------------------------------------------
Thank you, to be honest I couldn't come up with a good name for the option that
is not too long and self-describing. read_write_private looks good!
One minor correction. The help text here
https://github.com/apache/thrift/commit/70219e108a01340380f65e1ece8d63620d5e22a5#diff-1b57800912b80e54a5fb23aee7873271R3554
looks wrong: 'private_read_write:' -> 'read_write_private='
> Add an option to thrift go generator to make Read and Write methods private
> ---------------------------------------------------------------------------
>
> Key: THRIFT-3150
> URL: https://issues.apache.org/jira/browse/THRIFT-3150
> Project: Thrift
> Issue Type: Improvement
> Components: Go - Compiler
> Affects Versions: 0.9.2
> Reporter: Konstantin Shaposhnikov
> Assignee: Konstantin Shaposhnikov
> Fix For: 0.9.3
>
>
> I propose to add a new option *dont_export_rw* to go generator that if set
> will make it generate private read() and wirte() methods instead of public
> ones. E.g.:
> {code}
> func (p *Statistics) read(iprot thrift.TProtocol) error {
> ...
> }
> func (p *Statistics) write(oprot thrift.TProtocol) error {
> ....
> }
> {code}
> This will allow (along with THRIFT-3149) to generate a package that doesn't
> reference any symbols from Thrift Go library in public API.
> There are two main benefits:
> - keeping API of generated packages clean (only generated types are exported)
> - allowing to generate packages that can use vendored thrift library (e.g.
> placed inside internal/ directory).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
