Github user henrique commented on the pull request:
https://github.com/apache/thrift/pull/476#issuecomment-107496515
Hi Igor,
Yes, we missed that too, I fixed another syntax error for the travis
version of node but I see now that your unit-test is actually failing (I
initially thought it was only a CI problem).
https://travis-ci.org/henrique/thrift/jobs/64895282
Thanks again for your PR but I had to revert it, as I don't have time to
fix it myself. I would suggest that you make sure it runs on Travis before
resubmitting the pull request like described in:
https://github.com/itkach/thrift/blob/master/CONTRIBUTING.md#contributing-via-github-pull-requests
Cheers,
Henrique
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
