Github user henrique commented on the pull request:
https://github.com/apache/thrift/pull/476#issuecomment-101781028
e.g. lib/js/test/deep-constructor.test.js ?
So more duplication, except it also needs to be rewritten for the
different test runner js uses
It looks like we are going nowhere here, but yes they are two different
libraries and need to be tested twice; I don't mind how. If you have another
idea just let us know.
An alternative would be to add a compiler option in
t_js_generator.cc
What would the option do?
I meant to make these changes (THRIFT-3122) optional. e.g thrift --gen
js:jquery --gen node:convert-plain. But this is not a requirement.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
