[
https://issues.apache.org/jira/browse/THRIFT-3182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14616946#comment-14616946
]
ASF GitHub Bot commented on THRIFT-3182:
----------------------------------------
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/512#discussion_r34060609
--- Diff:
lib/java/src/org/apache/thrift/transport/TInvalidFrameSizeException.java ---
@@ -0,0 +1,29 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.thrift.transport;
+
+public class TInvalidFrameSizeException extends TTransportException {
--- End diff --
This would be simpler as a
TTransportException(TTransportExceptionType::CORRUPTED_DATA) (from C++).
That's the convention currently in the code, to use an exception type, not to
derive. I agree with you in principle as it is easier to unit test changes
with specific exception types, just want to point out if doesn't follow the
project's currently established conventions.
At the very least, the TInvalidFrameSizeException should initialize super
with that exception type code.
> TFramedTransport is in an invalid state after frame size exception
> ------------------------------------------------------------------
>
> Key: THRIFT-3182
> URL: https://issues.apache.org/jira/browse/THRIFT-3182
> Project: Thrift
> Issue Type: Bug
> Components: Java - Library
> Affects Versions: 0.9.2
> Reporter: Marshall Scorcio
>
> https://github.com/apache/thrift/pull/512
> This is necessary because after reading the invalid
> frame size from the underlying transport the transport
> is left in a bad state. Any following reads will
> likely throw more invalid frame size exceptions and
> if they don’t they will be reading corrupted messages.
> Closing forces the caller to discard the connection and
> get a new one.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
