[
https://issues.apache.org/jira/browse/THRIFT-3182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14617408#comment-14617408
]
ASF GitHub Bot commented on THRIFT-3182:
----------------------------------------
Github user marshalium commented on a diff in the pull request:
https://github.com/apache/thrift/pull/512#discussion_r34090086
--- Diff:
lib/java/src/org/apache/thrift/transport/TInvalidFrameSizeException.java ---
@@ -0,0 +1,29 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.thrift.transport;
+
+public class TInvalidFrameSizeException extends TTransportException {
--- End diff --
Fair enough. I'll add CORRUPTED_DATA to TTransportException and start
throwing a TTransportException with that type instead of a
TInvalidFrameSizeException.
> TFramedTransport is in an invalid state after frame size exception
> ------------------------------------------------------------------
>
> Key: THRIFT-3182
> URL: https://issues.apache.org/jira/browse/THRIFT-3182
> Project: Thrift
> Issue Type: Bug
> Components: Java - Library
> Affects Versions: 0.9.2
> Reporter: Marshall Scorcio
>
> https://github.com/apache/thrift/pull/512
> This is necessary because after reading the invalid
> frame size from the underlying transport the transport
> is left in a bad state. Any following reads will
> likely throw more invalid frame size exceptions and
> if they don’t they will be reading corrupted messages.
> Closing forces the caller to discard the connection and
> get a new one.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
