[
https://issues.apache.org/jira/browse/THRIFT-557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14733234#comment-14733234
]
ASF GitHub Bot commented on THRIFT-557:
---------------------------------------
GitHub user collinmsn opened a pull request:
https://github.com/apache/thrift/pull/601
add 'coding' option for python code generation
to fix the issue https://issues.apache.org/jira/browse/THRIFT-557
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/collinmsn/thrift master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/601.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #601
----
commit 58c213365f44647a0c844f34e970f439d873f1b2
Author: zhenghuabin <zhenghua...@bytedance.com>
Date: 2015-09-07T04:07:29Z
add 'coding' option for python code generation
thrift issues THRIFT-557
----
> charset problem with file Autogenerated by Thrift
> -------------------------------------------------
>
> Key: THRIFT-557
> URL: https://issues.apache.org/jira/browse/THRIFT-557
> Project: Thrift
> Issue Type: Bug
> Components: Python - Compiler
> Environment: ubuntu 9.04,python 2.6
> Reporter: nick fan
> Priority: Minor
>
> i find maybe a problem with the thrift idl file
> i wrote some struct comment in the idl file with chinese characters
> (Non-ASCII character ).
> then i use thrift generated the python code, it doesn't contains the encoding
> set comment line:
> {code}# -*- coding: utf-8 -*-{code}
> when i try to run the serv code ,it's cause SyntaxError: Non-ASCII character
> '\xxx' in file
> maybe we should make a command line option for user to set the encoding.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
