[
https://issues.apache.org/jira/browse/THRIFT-557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14741483#comment-14741483
]
ASF GitHub Bot commented on THRIFT-557:
---------------------------------------
Github user Jens-G commented on the pull request:
https://github.com/apache/thrift/pull/601#issuecomment-139653804
Correct me if I'm wrong, but isn't the "magic comment" [expected to have a
very specific format](https://www.python.org/dev/peps/pep-0263/)? The patch
seems not to provide that ...
> charset problem with file Autogenerated by Thrift
> -------------------------------------------------
>
> Key: THRIFT-557
> URL: https://issues.apache.org/jira/browse/THRIFT-557
> Project: Thrift
> Issue Type: Bug
> Components: Python - Compiler
> Environment: ubuntu 9.04,python 2.6
> Reporter: nick fan
> Priority: Minor
>
> i find maybe a problem with the thrift idl file
> i wrote some struct comment in the idl file with chinese characters
> (Non-ASCII character ).
> then i use thrift generated the python code, it doesn't contains the encoding
> set comment line:
> {code}# -*- coding: utf-8 -*-{code}
> when i try to run the serv code ,it's cause SyntaxError: Non-ASCII character
> '\xxx' in file
> maybe we should make a command line option for user to set the encoding.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
