GitHub user nsuke opened a pull request:
https://github.com/apache/thrift/pull/680
Thrift 1857 redux 2
Rational:
* No TType.UTF8 (don't break cross-lang compatibility)
* No six.BufferIO (don't break fastbinary)
* Don't make py2 read/writeString UTF8 (don't break backward API
compatibility)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nsuke/thrift THRIFT-1857-redux-2
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/680.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #680
----
commit d516da27b8f329e0827219bd47da02356b2eef92
Author: Thomas Bartelmess <[email protected]>
Date: 2014-04-30T20:21:05Z
Python 3 support
Added six to install_requires in setup.py
commit d3d1e4e2e43823c07c5000882a3e1d63935b124d
Author: Eevee (Alex Munroe) <[email protected]>
Date: 2014-08-19T23:07:36Z
Fix useless warnings about a broken C extension on 3.x, PyPy, etc.
Also remove use_2to3, since this is supposed to be single-codebase now.
commit 3d755dbabe880edca4b5e306f53d00fd03998406
Author: Eevee (Alex Munroe) <[email protected]>
Date: 2014-08-19T23:12:16Z
Fix a few minor nitpicks with the Python 3 fixes.
commit 6295a64a0fe9b489fa49e03068ffbb4b079e1872
Author: Eevee (Alex Munroe) <[email protected]>
Date: 2014-08-19T23:28:07Z
JSONProtocol's constants need to be bytestrings.
commit 4eee7c76a03d97c3e8f5b6355236b6131ad2182f
Author: Eevee (Alex Munroe) <[email protected]>
Date: 2014-08-19T23:28:55Z
Use print_function in the Python tests.
commit c646c9360995b659e913df94cc6d7a2a5db858e8
Author: Eevee (Alex Munroe) <[email protected]>
Date: 2014-08-19T23:29:09Z
Unbreak the Python tests when the C extension doesn't exist.
If there's no C part, everything gets built into `build/lib/`, but the
shell globs were looking for a dot.
commit ae60057e6adc233ffda2b515760ebea477947891
Author: Eevee (Alex Munroe) <[email protected]>
Date: 2014-08-19T23:30:06Z
Trailing whitespace my editor fixed for me.
commit 67aab994e7f41e23373c08e3853d790700010651
Author: Eevee (Alex Munroe) <[email protected]>
Date: 2014-08-20T02:53:07Z
Probably don't need this 2.4 compat any more.
commit a679eec6f4b11e3373e5b55e192fce36f613136b
Author: Eevee (Alex Munroe) <[email protected]>
Date: 2014-08-20T02:53:20Z
Stop generating code that contains xrange and iteritems.
commit 4a45fe5904be3e6d9df9c3be9c2d67421e2226ac
Author: Eevee (Alex Munroe) <[email protected]>
Date: 2014-08-20T02:53:50Z
Make JSON and compact protocols use bytes everywhere.
commit f692770e967debb149b0ae18e9fce72230e17272
Author: Eevee (Alex Munroe) <[email protected]>
Date: 2014-08-20T02:54:31Z
Python 3 support in test/py/.
commit 774fc7884d938c57887a5b1ea8839212c1c5ee94
Author: Eevee (Alex Munroe) <[email protected]>
Date: 2014-08-20T02:54:44Z
Miscellaneous module moves and text/bytes stuff that was missed.
commit d0a36c1c587c2ca7261dd51b8036d1bf516868b7
Author: Eevee (Alex Munroe) <[email protected]>
Date: 2014-08-20T03:14:21Z
Fix more sys.path.insert glob shenanigans.
commit 19bd44462ae29cc527c1e6e9fe9540e35bd22d9d
Author: Eevee (Alex Munroe) <[email protected]>
Date: 2014-08-20T03:43:51Z
Fix a bad relativized import.
commit 99cc4360fcdc8ee4ca81c4f62c9b972a2096778d
Author: Eevee (Alex Munroe) <[email protected]>
Date: 2014-08-20T03:46:13Z
Run 2to3 on the Python tutorial code.
commit b05fdd2d8b0350a3a1c65be96fff14123911eaa1
Author: Eevee (Alex Munroe) <[email protected]>
Date: 2014-08-20T04:08:50Z
Don't compile to itervalues, either.
commit 5aaa2bb707a1a8fee12ea8e74db9dcaaf0fc1ed7
Author: Eevee (Alex Munroe) <[email protected]>
Date: 2014-08-20T04:09:06Z
Fix passing a float to struct.pack() -- tolerated in 2, not 3.
commit 1bc93b53ec92d2f9e968a370581a411ddde9551a
Author: Eevee (Alex Munroe) <[email protected]>
Date: 2014-09-11T22:42:50Z
And one more round of fixing JSON decoding.
commit 8d54badced75eb1913820b296922f011d9753334
Author: helgridly <[email protected]>
Date: 2015-03-19T20:09:04Z
Restored some logging objects that got stomped on during the rebase
commit 586505ea40709cb32130d6313d1307162c3fcaeb
Author: helgridly <[email protected]>
Date: 2015-03-19T21:40:52Z
Replaced cStringIO with six.BytesIO
commit e6ecc28242166324694cd7526f40a46aa34769d5
Author: Nobuaki Sukegawa <[email protected]>
Date: 2015-11-03T12:32:41Z
Fix compilation
commit 29d8b73dd1009ec9e1b3c4afc69b4a2663f87efc
Author: Nobuaki Sukegawa <[email protected]>
Date: 2015-11-03T12:32:47Z
Fix fastbinary for py2, read/writeString for py2 and py3
commit 93bdbde1d15320773cd44b788046548f1cd1f3fc
Author: Nobuaki Sukegawa <[email protected]>
Date: 2015-11-03T15:05:23Z
Install six on CI
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
