[
https://issues.apache.org/jira/browse/THRIFT-3409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14993581#comment-14993581
]
ASF GitHub Bot commented on THRIFT-3409:
----------------------------------------
Github user asfgit closed the pull request at:
https://github.com/apache/thrift/pull/681
> NodeJS binary field issues
> --------------------------
>
> Key: THRIFT-3409
> URL: https://issues.apache.org/jira/browse/THRIFT-3409
> Project: Thrift
> Issue Type: Sub-task
> Components: Node.js - Library
> Reporter: Aki Sukegawa
> Assignee: Aki Sukegawa
>
> There's at least 3 problems in NodeJS binary field.
> # API are inconsistent across binary/comact/JSON protocols
> # compact/JSON wire format is imcompatible with other languages
> (JSON : THRIFT-3200)
> # size of compact wire format is 2x of the original binary
> I propose following changes to fix this
> # Change JSON protocol return value from string to Buffer (same as
> binary/compact)
> # Change JSON protocol wire format to Base64 (same as other languages)
> # Change compact protocol wire format to plain binary (same as other
> languages)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
