[
https://issues.apache.org/jira/browse/THRIFT-3409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14993605#comment-14993605
]
Hudson commented on THRIFT-3409:
--------------------------------
SUCCESS: Integrated in Thrift #1715 (See
[https://builds.apache.org/job/Thrift/1715/])
THRIFT-3409 NodeJS binary field issues Client: Node.js Patch: Nobuaki (nsuke:
rev 8a4d06febe8bc2e1bd84f955b1c2f0149665a0be)
* lib/nodejs/lib/thrift/json_protocol.js
* lib/nodejs/lib/thrift/compact_protocol.js
* test/known_failures_Linux.json
* lib/nodejs/lib/thrift/binary_protocol.js
* lib/nodejs/test/test_driver.js
> NodeJS binary field issues
> --------------------------
>
> Key: THRIFT-3409
> URL: https://issues.apache.org/jira/browse/THRIFT-3409
> Project: Thrift
> Issue Type: Sub-task
> Components: Node.js - Library
> Reporter: Aki Sukegawa
> Assignee: Aki Sukegawa
> Fix For: 1.0
>
>
> There's at least 3 problems in NodeJS binary field.
> # API are inconsistent across binary/comact/JSON protocols
> # compact/JSON wire format is imcompatible with other languages
> (JSON : THRIFT-3200)
> # size of compact wire format is 2x of the original binary
> I propose following changes to fix this
> # Change JSON protocol return value from string to Buffer (same as
> binary/compact)
> # Change JSON protocol wire format to Base64 (same as other languages)
> # Change compact protocol wire format to plain binary (same as other
> languages)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
