[
https://issues.apache.org/jira/browse/THRIFT-3200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15005362#comment-15005362
]
ASF GitHub Bot commented on THRIFT-3200:
----------------------------------------
GitHub user nsuke opened a pull request:
https://github.com/apache/thrift/pull/698
THRIFT-3200 JS and nodejs do not encode JSON protocol binary fields a…
…s base64
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nsuke/thrift THRIFT-3200
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/698.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #698
----
commit 14a8b158f99760885af74e7af9a1411cf5b985e6
Author: Nobuaki Sukegawa <[email protected]>
Date: 2015-11-14T08:36:29Z
THRIFT-3200 JS and nodejs do not encode JSON protocol binary fields as
base64
----
> JS and nodejs do not encode JSON protocol binary fields as base64
> -----------------------------------------------------------------
>
> Key: THRIFT-3200
> URL: https://issues.apache.org/jira/browse/THRIFT-3200
> Project: Thrift
> Issue Type: Bug
> Components: JavaScript - Library, Node.js - Library
> Affects Versions: 0.9.2
> Reporter: Adam Beberg
> Assignee: Aki Sukegawa
> Fix For: 1.0
>
>
> Binary fields in the JSON protocol are base64 encoded in
> cpp/go/java/rb/py/go/... All code with JSON implementations except javascript
> and nodejs - which escape them as if they as strings (unfinished
> implementation). This makes js/nodejs incompatable with any other languages
> since JSON is their only supported protocol. To fix this js/nodejs need to be
> corrected, but this will break backward compatibility.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
