[ 
https://issues.apache.org/jira/browse/THRIFT-3200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15005735#comment-15005735
 ] 

Hudson commented on THRIFT-3200:
--------------------------------

SUCCESS: Integrated in Thrift #1730 (See 
[https://builds.apache.org/job/Thrift/1730/])
THRIFT-3200 JS and nodejs do not encode JSON protocol binary fields as (nsuke: 
rev 6defea5f7b22ed539ad136ddd3ca09fc8352fffd)
* lib/js/test/phantom-client.js
* lib/js/src/thrift.js
* lib/js/Gruntfile.js
* test/tests.json
* lib/js/test/test.js


> JS and nodejs do not encode JSON protocol binary fields as base64
> -----------------------------------------------------------------
>
>                 Key: THRIFT-3200
>                 URL: https://issues.apache.org/jira/browse/THRIFT-3200
>             Project: Thrift
>          Issue Type: Bug
>          Components: JavaScript - Library, Node.js - Library
>    Affects Versions: 0.9.2
>            Reporter: Adam Beberg
>            Assignee: Aki Sukegawa
>             Fix For: 1.0
>
>
> Binary fields in the JSON protocol are base64 encoded in 
> cpp/go/java/rb/py/go/... All code with JSON implementations except javascript 
> and nodejs - which escape them as if they as strings (unfinished 
> implementation). This makes js/nodejs incompatable with any other languages 
> since JSON is their only supported protocol. To fix this js/nodejs need to be 
> corrected, but this will break backward compatibility.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to