GitHub user bracki opened a pull request:
https://github.com/apache/thrift/pull/707
Fix generated Node JS code
As reported in https://issues.apache.org/jira/browse/THRIFT-1840 and
https://issues.apache.org/jira/browse/THRIFT-2527 the generated JS code
pollutes the global namespace because it lacks `var` keywords.
This PR adds the `var` keyword where appropriate.
It also appends missing `;`, thus making tools like
[jshint](http://jshint.com/) et. al. happier.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Jimdo/thrift fix_generated_node_js_code
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/707.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #707
----
commit 09382cd93cc5b0a19ad5f2e92dae6b83987968ad
Author: Jan Brauer <[email protected]>
Date: 2015-11-18T20:40:58Z
Don't pollute global namespace
commit 6c6df500f10b90aa1b9ab733b2b863b1c65ac0c6
Author: Jan Brauer <[email protected]>
Date: 2015-11-18T20:42:26Z
Add missing semicolons
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
