Github user cjthompson commented on the pull request:
https://github.com/apache/thrift/pull/707#issuecomment-158525127
Looking at this change, I believe this will break namespacing because the
output will be invalid JavaScript:
````javascript
var Namespace.Object.Type = {}
````
For namespacing to work, the namespace object would have to be declared at
the top of the file and the `var` keyword not used when adding to the namespace
object.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
