[
https://issues.apache.org/jira/browse/THRIFT-3145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15051303#comment-15051303
]
ASF GitHub Bot commented on THRIFT-3145:
----------------------------------------
GitHub user nsuke opened a pull request:
https://github.com/apache/thrift/pull/740
THRIFT-3145 JSON protocol does not handle bool and empty containers
correctly
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nsuke/thrift THRIFT-3145
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/740.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #740
----
commit d7ddaa61c0fb03c49daa02614c23103b466eb2cd
Author: Rhys Adams <[email protected]>
Date: 2015-05-12T00:51:00Z
THRIFT-3145 JSON protocol incompatible with (at least) Java implementation
Client: Haskell
Patch: Rhys Adams
Fix empty list and set read.
commit 157f937e8139a0c52efd93d585a59132045e5ed3
Author: Nobuaki Sukegawa <[email protected]>
Date: 2015-12-10T17:24:17Z
THRIFT-3145 JSON protocol incompatible with (at least) Java implementation
Fix bool and empty map and add test
----
> JSON protocol does not handle bool and empty containers correctly
> -----------------------------------------------------------------
>
> Key: THRIFT-3145
> URL: https://issues.apache.org/jira/browse/THRIFT-3145
> Project: Thrift
> Issue Type: Bug
> Components: Haskell - Library
> Affects Versions: 0.9.2, 0.9.3
> Reporter: Rhys Adams
> Assignee: Aki Sukegawa
> Attachments: thrift-fixes.patch
>
>
> I'm using Thrift to communicate with Apache Aurora and have had to make a
> couple of changes to the JSON protocol implementation, namely:
> * Write booleans as '1'/'0' instead of "true"/"false"
> * Parse empty lists
> The code appears identical in the current master branch. I've attached a
> patch with the changes I've made, but they've only been tested for my use
> case; I haven't looked at any specs.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
