[ 
https://issues.apache.org/jira/browse/THRIFT-3145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15054949#comment-15054949
 ] 

Hudson commented on THRIFT-3145:
--------------------------------

SUCCESS: Integrated in Thrift #1766 (See 
[https://builds.apache.org/job/Thrift/1766/])
THRIFT-3145 JSON protocol does not handle bool and empty containers (nsuke: rev 
f48e339cc99aab7f6206c360d4193dd9944ad156)
* lib/hs/src/Thrift/Protocol/JSON.hs
THRIFT-3145 JSON protocol does not handle bool and empty containers (nsuke: rev 
ef2b5285f3be08e52000a60d3de2e2f8a30f892b)
* test/known_failures_Linux.json
* lib/hs/test/JSONSpec.hs
* lib/hs/test/Spec.hs
* lib/hs/src/Thrift/Protocol/JSON.hs
* lib/hs/src/Thrift/Protocol.hs
* lib/hs/CMakeLists.txt


> JSON protocol does not handle bool and empty containers correctly
> -----------------------------------------------------------------
>
>                 Key: THRIFT-3145
>                 URL: https://issues.apache.org/jira/browse/THRIFT-3145
>             Project: Thrift
>          Issue Type: Bug
>          Components: Haskell - Library
>    Affects Versions: 0.9.2, 0.9.3
>            Reporter: Rhys Adams
>            Assignee: Aki Sukegawa
>             Fix For: 1.0
>
>         Attachments: thrift-fixes.patch
>
>
> I'm using Thrift to communicate with Apache Aurora and have had to make a 
> couple of changes to the JSON protocol implementation, namely:
> * Write booleans as '1'/'0' instead of "true"/"false"
> * Parse empty lists
> The code appears identical in the current master branch. I've attached a 
> patch with the changes I've made, but they've only been tested for my use 
> case; I haven't looked at any specs.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to