Github user kdubb commented on the pull request:
https://github.com/apache/thrift/pull/790#issuecomment-172362021
These do work with nested types so my hunch was wrong on that but with the
current code (including your PR) it now has awkward extra semi-colons; so my
munch was somewhat correct that they appear unnecessary
The NSSet missing a single brace was correct. I don't know why you switched
it to the longer syntax when you could have just added a brace.
It seems to me the issue was only to do with set literals and could have
been solved with a single character change (adding a brace). Is there some
other place I am missing where semi-colons are not added? If so I cannot seem
to find it.
Currently as generated...
```objc
NSDictionary<NSString *, NSString *> * tmp0 = @{@"new": @"world"};
MapConst = @{@"hello": tmp0};
;
NSSet<NSString *> * tmp1 = [[NSSet alloc] initWithArray:@[@"hello"]];
SetConst = [[NSSet alloc] initWithArray:@[tmp1]];
;
NSArray<NSString *> * tmp2 = @[@"hello"];
ArrayConst = @[tmp2];
;
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---