Github user ChristopherRogers commented on the pull request:
https://github.com/apache/thrift/pull/790#issuecomment-172571012
Ah, my apologies for the extra semicolons. It was missing semicolons in the
default init methods where a collection type had a default value.
I believe this semicolon problem is due to discrepancies in how the caller
of this method assumes code will be generated--with semicolons and line breaks
or not. I think if the call sites were to be cleaned up the ugliness would go
away. I believe I checked them but I might've overlooked them. I'll give it
another look again later too.
The NSSet change should've been in another PR, I admit, but it was for
performance reasons (since one of Thrift's main goals is performance). I
believe that optimized ARC code cannot cancel out the autorelease that
setWithArray makes because Foundation isn't using ARC itself (I think, but it's
worth testing.) Even if it could I think it's still faster to not have to have
it back out of autoreleasing. I considered changing it to the initWithObjects
variant but it seemed a little too drastic and needs performance testing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
