[
https://issues.apache.org/jira/browse/THRIFT-3627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15146817#comment-15146817
]
Kazuki Matsuda commented on THRIFT-3627:
----------------------------------------
I read [https://github.com/felixge/node-style-guide]
Double quotes. https://github.com/felixge/node-style-guide#use-single-quotes
Single quotes recommended. I have no strong opinion about it.
But consistency had been lost. And fixjsstyle collect also.
Removing trailing commas.
https://github.com/felixge/node-style-guide#object--array-creation
Actually, I like trailing commas and style guide also required trailing commas.
Bnd fixjsstyle remove it.
If we like trailing commas. We may need jslint common settings.
Removing quotes from object keys.
https://github.com/felixge/node-style-guide#object--array-creation
Style guide recommend "Only quote keys when your interpreter complains:".
Anyway, there are many coding style. I hope that white-space and quotes fixed
at least.
> Missing basic code style consistency of JavaScript.
> ---------------------------------------------------
>
> Key: THRIFT-3627
> URL: https://issues.apache.org/jira/browse/THRIFT-3627
> Project: Thrift
> Issue Type: Improvement
> Components: JavaScript - Library
> Reporter: Kazuki Matsuda
> Priority: Minor
>
> E.g.)
> * No white space in {code}function(args){// beteween `){`{code}
> https://github.com/apache/thrift/blob/84cf363eeedf4cc9bb618bb2b1980696b9f6fc9b/lib/js/src/thrift.js#L1497
> * "Double quoted" (not 'single quoted') string litteral
> https://github.com/apache/thrift/blob/84cf363eeedf4cc9bb618bb2b1980696b9f6fc9b/lib/js/src/thrift.js#L133
> Those errors can be easily fixed by fixjsstyle.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
