[
https://issues.apache.org/jira/browse/THRIFT-3627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15148604#comment-15148604
]
Aki Sukegawa commented on THRIFT-3627:
--------------------------------------
Consistency is a good point.
In that case, the right way would be to update lib/nodejs/coding_standards.md
and then apply the changes.
Are you interested in this ?
It can be as simple as our C++ version that only states "our settings for tool
X is here"
Quote rules might be worth noting as they're not covered by
doc/coding_standards.md, though.
I would want at least another committer or two to review/approve to land the
standard update.
As to the trailing comma, I also prefer rather always putting them because it's
better for history when appending elements.
I suspect the fixjsstyle rule might have stemmed from ancient browser support.
> Missing basic code style consistency of JavaScript.
> ---------------------------------------------------
>
> Key: THRIFT-3627
> URL: https://issues.apache.org/jira/browse/THRIFT-3627
> Project: Thrift
> Issue Type: Improvement
> Components: JavaScript - Library
> Reporter: Kazuki Matsuda
> Priority: Minor
>
> E.g.)
> * No white space in {code}function(args){// beteween `){`{code}
> https://github.com/apache/thrift/blob/84cf363eeedf4cc9bb618bb2b1980696b9f6fc9b/lib/js/src/thrift.js#L1497
> * "Double quoted" (not 'single quoted') string litteral
> https://github.com/apache/thrift/blob/84cf363eeedf4cc9bb618bb2b1980696b9f6fc9b/lib/js/src/thrift.js#L133
> Those errors can be easily fixed by fixjsstyle.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
