Github user nsuke commented on the pull request:
https://github.com/apache/thrift/pull/945#issuecomment-198408886
> happybase use isOpen (after all there is no other method to do so) to
check if it need to reopen the connection
isOpen call seems to be for only lazy initialization but it might not the
point we should discuss in here.
Just one more thing for happybase: from what I read in their [except:
block](https://github.com/wbolster/happybase/blob/9cbd718c10a3089f234f1eac1236b631e1f8e7cd/happybase/pool.py#L141)
I have impression that they may like your contribution.
If happybase's pool needs something similar to urllib3's pool, it's
perfectly possible without modifying Thrift: just store TSocket instance and
use its `handle` attribute.
That way, the validation can be much simpler (and yet more complete) than
this, because you can make a lot of assumptions which are specific to your use
case.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
