[
https://issues.apache.org/jira/browse/THRIFT-3799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15263248#comment-15263248
]
Jens Geyer commented on THRIFT-3799:
------------------------------------
Sorry, but I'm against this patch.
While it clearly does make the code elegant, we get this at the cost of the
newly introduced risk of potential incomaptible behaviour. A good portion of
these constants are used across languages, hence they are part of the implicit
underlying Thrift API. So consequently, to make sure the values are correct we
would at least need test cases for these, and that essentially would render the
whole elegancy away.
IMHO we should keep it as it is now.
> Make constants to use iota
> --------------------------
>
> Key: THRIFT-3799
> URL: https://issues.apache.org/jira/browse/THRIFT-3799
> Project: Thrift
> Issue Type: Improvement
> Components: Go - Library
> Reporter: Mahendran Kathirvel
> Priority: Minor
> Labels: easyfix
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> Now, the constants and enumerations are using hardcoded values but Go has a
> elegant way of doing this by using `Iota`
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
