[
https://issues.apache.org/jira/browse/THRIFT-3799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15264023#comment-15264023
]
Jens Geyer commented on THRIFT-3799:
------------------------------------
> understand what you mean but I don't see any risk in here.
I do.
> to be initialised while keeping "their value" same
Today. You need only one additional value in between of existing ones to screw
things up. Even if this is a small risk, the "elegance" and "idiomatic go" and
"everyone does it this way these days" gained from it is not enough to
outweight that risk.
> The 'Go' community encourages to use `iota` declaration
Encourages does not read "anything else is wrong2. It's just a recommendation.
We don't have to follow blindy like the lemmings.
> Alright, let me write the test cases for the changes
Honestly?
> Make constants to use iota
> --------------------------
>
> Key: THRIFT-3799
> URL: https://issues.apache.org/jira/browse/THRIFT-3799
> Project: Thrift
> Issue Type: Improvement
> Components: Go - Library
> Reporter: Mahendran Kathirvel
> Priority: Minor
> Labels: easyfix
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> Now, the constants and enumerations are using hardcoded values but Go has a
> elegant way of doing this by using `Iota`
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
