[
https://issues.apache.org/jira/browse/THRIFT-3787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15273565#comment-15273565
]
Randy Abernethy commented on THRIFT-3787:
-----------------------------------------
Hey James,
Regarding this particular hunk, from the Node docs:
"For all EventEmitter objects, if an 'error' event handler is not provided, the
error will be thrown, causing the Node.js process to report an unhandled
exception and crash unless either: The domain module is used appropriately or a
handler has been registered for the process.on('uncaughtException') event."
So while this code predates me I think it was trying to protect user code from
spurious exceptions. Unless you have a different view I'd rather leave this
hunk in place (until we get your deep refactor!).
The other changes look good (particularly the ssl test below). Let me know if
you want to commit the other hunks.
-Randy
> Node.js Connection object doesn't handle errors correctly
> ---------------------------------------------------------
>
> Key: THRIFT-3787
> URL: https://issues.apache.org/jira/browse/THRIFT-3787
> Project: Thrift
> Issue Type: Bug
> Components: Node.js - Library
> Reporter: James Reggio
> Assignee: Randy Abernethy
> Priority: Minor
>
> There are a handful of operation-ordering problems in the
> Connection.prototype.connection_gone() method and its friends.
> See the pull request for more details.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
