[ 
https://issues.apache.org/jira/browse/THRIFT-3787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15276555#comment-15276555
 ] 

James Reggio commented on THRIFT-3787:
--------------------------------------

[~codesf], I reverted the hunk around the 'error' event.

Minor request: when you commit patches, could you include the '--author 
"[email protected]"' flag to maintain attribution to the original 
contributor? If you look at the project commit history, you'll see other 
maintainers adopting this practice (the little picture-in-picture avatar 
indicates this behavior): https://github.com/apache/thrift/commits/master

> Node.js Connection object doesn't handle errors correctly
> ---------------------------------------------------------
>
>                 Key: THRIFT-3787
>                 URL: https://issues.apache.org/jira/browse/THRIFT-3787
>             Project: Thrift
>          Issue Type: Bug
>          Components: Node.js - Library
>            Reporter: James Reggio
>            Assignee: Randy Abernethy
>            Priority: Minor
>
> There are a handful of operation-ordering problems in the 
> Connection.prototype.connection_gone() method and its friends.
> See the pull request for more details.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to