[
https://issues.apache.org/jira/browse/THRIFT-3845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15308163#comment-15308163
]
ASF GitHub Bot commented on THRIFT-3845:
----------------------------------------
GitHub user RobberPhex opened a pull request:
https://github.com/apache/thrift/pull/1022
THRIFT-3845
use `isBinaryAccelerated` to indicate use extension `thrift_protocol`.
When `TBinaryProtocolAccelerated` warped in
`TMultiplexedProtocol`,extension `thrift_protocol` can also be used for `client
serialization`, `client deserialization`, `server serialization`.
notice: `server deserialization` can't use extension `thrift_protocol`.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/RobberPhex/thrift THRIFT-3845
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/1022.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1022
----
commit 30d3fb6000f84d401884a7799f2a96a08930e917
Author: Robert Lu <[email protected]>
Date: 2016-05-31T15:38:18Z
add isStrict{Read,Write} to TProtocolDecorator for
TBinaryProtocolAccelerated
commit 2b9005a49c299ab444a21d61e38b1714f294f5cf
Author: Robert Lu <[email protected]>
Date: 2016-05-31T16:39:06Z
add isBinaryAccelerated for thrift_protocol ext
instanceof TBinaryProtocolAccelerated will caused
TBinaryProtocolAccelerated warped in TMultiplexedProtocol can't use
thrift_protocol extension
----
> TBinaryProtocolAccelerated cannot use thrift_protocol ext
> ---------------------------------------------------------
>
> Key: THRIFT-3845
> URL: https://issues.apache.org/jira/browse/THRIFT-3845
> Project: Thrift
> Issue Type: Improvement
> Components: PHP - Compiler, PHP - Library
> Affects Versions: 0.9.3
> Environment: PHP7 with thrift 0.9.3, with thrift_protocol, at OS X
> 10.11
> Reporter: Robert Lu
> Priority: Minor
>
> compiler generate phpcode:
> instanceof TBinaryProtocolAccelerated
> to indicate use thrift_protocol, but when TBinaryProtocolAccelerated warped
> in TMultiplexedProtocol, thrift_protocol doesn't used, because
> TMultiplexedProtocol isn't TBinaryProtocolAccelerated's instence.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
