[
https://issues.apache.org/jira/browse/THRIFT-3845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15521147#comment-15521147
]
ASF GitHub Bot commented on THRIFT-3845:
----------------------------------------
Github user nsuke commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1022#discussion_r80386881
--- Diff: lib/php/lib/Thrift/Protocol/TBinaryProtocolAccelerated.php ---
@@ -62,4 +62,9 @@ public function isStrictWrite()
{
return $this->strictWrite_;
}
+
+ public function isBinaryAccelerated()
+ {
+ return true;
+ }
--- End diff --
I agree we need something like this but the name can be more general.
For example, `isAccelerated` or even `isDynamic`.
(Thinks about the day when we add TCompactProtocolAccelerated or anything
without generated read/write calls...)
> TBinaryProtocolAccelerated cannot use thrift_protocol ext
> ---------------------------------------------------------
>
> Key: THRIFT-3845
> URL: https://issues.apache.org/jira/browse/THRIFT-3845
> Project: Thrift
> Issue Type: Improvement
> Components: PHP - Compiler, PHP - Library
> Affects Versions: 0.9.3
> Environment: PHP7 with thrift 0.9.3, with thrift_protocol, at OS X
> 10.11
> Reporter: Robert Lu
> Priority: Minor
>
> compiler generate phpcode:
> instanceof TBinaryProtocolAccelerated
> to indicate use thrift_protocol, but when TBinaryProtocolAccelerated warped
> in TMultiplexedProtocol, thrift_protocol doesn't used, because
> TMultiplexedProtocol isn't TBinaryProtocolAccelerated's instence.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
