[
https://issues.apache.org/jira/browse/THRIFT-3849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15317079#comment-15317079
]
ASF GitHub Bot commented on THRIFT-3849:
----------------------------------------
Github user brianshannan-wf commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1023#discussion_r65955275
--- Diff: lib/dart/lib/src/serializer/t_serializer.dart ---
@@ -0,0 +1,43 @@
+/// Licensed to the Apache Software Foundation (ASF) under one
+/// or more contributor license agreements. See the NOTICE file
+/// distributed with this work for additional information
+/// regarding copyright ownership. The ASF licenses this file
+/// to you under the Apache License, Version 2.0 (the
+/// "License"); you may not use this file except in compliance
+/// with the License. You may obtain a copy of the License at
+///
+/// http://www.apache.org/licenses/LICENSE-2.0
+///
+/// Unless required by applicable law or agreed to in writing,
+/// software distributed under the License is distributed on an
+/// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+/// KIND, either express or implied. See the License for the
+/// specific language governing permissions and limitations
+/// under the License.
+
+part of thrift;
+
+class TSerializer {
+ final message = new TMessage('Serializer', TMessageType.ONEWAY, 1);
+ TBufferedTransport transport;
+ TProtocol protocol;
+
+ TSerializer() {
+ this.transport = new TBufferedTransport();
--- End diff --
Would it be better to put these as optional arguments in the constructor
with the buffered transport/binary protocol as the defaults?
> Port Go serializer and deserializer to dart
> -------------------------------------------
>
> Key: THRIFT-3849
> URL: https://issues.apache.org/jira/browse/THRIFT-3849
> Project: Thrift
> Issue Type: Improvement
> Components: Dart - Library
> Reporter: Keaton
> Assignee: Keaton
>
> Port the Go Serializer/Deserializer over to dart.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
