[
https://issues.apache.org/jira/browse/THRIFT-3849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15317403#comment-15317403
]
ASF GitHub Bot commented on THRIFT-3849:
----------------------------------------
Github user markerickson-wf commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1023#discussion_r65980877
--- Diff: lib/dart/lib/src/transport/t_buffered_transport.dart ---
@@ -22,13 +22,13 @@ class TBufferedTransport extends TTransport {
final List<int> _writeBuffer = [];
Iterator<int> _readIterator;
- Uint8List _consumeWriteBuffer() {
+ Uint8List consumeWriteBuffer() {
Uint8List buffer = new Uint8List.fromList(_writeBuffer);
_writeBuffer.clear();
return buffer;
}
- void _setReadBuffer(Uint8List readBuffer) {
+ void setReadBuffer(Uint8List readBuffer) {
--- End diff --
I don't think you need to change the visibility of this method here and in
all of the subclasses.
> Port Go serializer and deserializer to dart
> -------------------------------------------
>
> Key: THRIFT-3849
> URL: https://issues.apache.org/jira/browse/THRIFT-3849
> Project: Thrift
> Issue Type: Improvement
> Components: Dart - Library
> Reporter: Keaton
> Assignee: Keaton
>
> Port the Go Serializer/Deserializer over to dart.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
