[
https://issues.apache.org/jira/browse/THRIFT-3876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15380295#comment-15380295
]
ASF GitHub Bot commented on THRIFT-3876:
----------------------------------------
Github user oprudkyi commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1045#discussion_r71053129
--- Diff: lib/haxe/src/org/apache/thrift/transport/THttpClient.hx ---
@@ -39,12 +46,25 @@ class THttpClient extends TTransport {
private var requestBuffer_ : BytesOutput = new BytesOutput();
private var responseBuffer_ : BytesInput = null;
+ #if !js
private var request_ : Http = null;
+ #else
+ private var request_ : JsHttp = null;
+ #end
public function new( requestUrl : String) : Void {
- request_ = new Http(requestUrl);
- request_.addHeader( "contentType", "application/x-thrift");
+ #if !js
+ request_ = new Http(requestUrl);
+ #else
+ request_ = new JsHttp(requestUrl);
+ request_.async = false;
+ #end
+ request_.addHeader("Content-Type", "application/x-thrift");
+ request_.addHeader("Accept", "application/x-thrift");
--- End diff --
this will need redesign of api as well, because transport doesn't have
access to protocol type information
> haxe js/nodejs client
> ---------------------
>
> Key: THRIFT-3876
> URL: https://issues.apache.org/jira/browse/THRIFT-3876
> Project: Thrift
> Issue Type: Improvement
> Components: Haxe - Library
> Reporter: Oleksii Prudkyi
> Assignee: Oleksii Prudkyi
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
