[
https://issues.apache.org/jira/browse/THRIFT-3876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15380692#comment-15380692
]
ASF GitHub Bot commented on THRIFT-3876:
----------------------------------------
Github user Jens-G commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1045#discussion_r71064928
--- Diff: lib/haxe/src/org/apache/thrift/transport/TFileStream.hx ---
@@ -24,6 +24,9 @@ import haxe.io.BytesBuffer;
import haxe.io.Input;
import haxe.io.Output;
+#if js
+import js.node.Fs;
+#end
--- End diff --
> Well, the haxe by self is such
This is a code smell, no matter what "the haxe" thinks. But not blocking
issue for the commit.
> anyway this file is mostly used for tests
That's why it says "TTestFileStream"? No, wait ... it doesn't. Joking
aside, why do you want to limit the usage artifically by saying "oh, this is
only test stuff? I see a slass that may be used for other purposes.
> haxe js/nodejs client
> ---------------------
>
> Key: THRIFT-3876
> URL: https://issues.apache.org/jira/browse/THRIFT-3876
> Project: Thrift
> Issue Type: Improvement
> Components: Haxe - Library
> Reporter: Oleksii Prudkyi
> Assignee: Oleksii Prudkyi
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
