Github user Jens-G commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1045#discussion_r71064928
--- Diff: lib/haxe/src/org/apache/thrift/transport/TFileStream.hx ---
@@ -24,6 +24,9 @@ import haxe.io.BytesBuffer;
import haxe.io.Input;
import haxe.io.Output;
+#if js
+import js.node.Fs;
+#end
--- End diff --
> Well, the haxe by self is such
This is a code smell, no matter what "the haxe" thinks. But not blocking
issue for the commit.
> anyway this file is mostly used for tests
That's why it says "TTestFileStream"? No, wait ... it doesn't. Joking
aside, why do you want to limit the usage artifically by saying "oh, this is
only test stuff? I see a slass that may be used for other purposes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
