Github user oprudkyi commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1045#discussion_r71065930
--- Diff: lib/haxe/src/org/apache/thrift/transport/TFileStream.hx ---
@@ -24,6 +24,9 @@ import haxe.io.BytesBuffer;
import haxe.io.Input;
import haxe.io.Output;
+#if js
+import js.node.Fs;
+#end
--- End diff --
as for me current implementation is better over scattering the same
functionality over different files
i.e. always visible 'original' implementation as well js part which just
reimplements original one in target depended way
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
