[ 
https://issues.apache.org/jira/browse/THRIFT-3880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15382196#comment-15382196
 ] 

ASF GitHub Bot commented on THRIFT-3880:
----------------------------------------

Github user nsuke commented on the issue:

    https://github.com/apache/thrift/pull/1049
  
    @binaryseed thanks, I've verified your patch locally and it does fix the 
problem. It'll be merged soon.
    
    I'm also working on extending cross tests so that we can assert true/false 
and endianess which cannot be verified by current round trip tests.


> Erlang Compact protocol - boolean values inverted
> -------------------------------------------------
>
>                 Key: THRIFT-3880
>                 URL: https://issues.apache.org/jira/browse/THRIFT-3880
>             Project: Thrift
>          Issue Type: Bug
>          Components: Erlang - Library
>            Reporter: Vince Foley
>
> Upon using thrift's erlang compact protocol, I noticed that all of the 
> boolean values are inverted.
> It turns out that the binary values used for thrift boolean values are set 
> wrong, and don't match those used by other languages.
> I've prepared a PR for this issue: https://github.com/apache/thrift/pull/1049



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to