[
https://issues.apache.org/jira/browse/THRIFT-3880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15382384#comment-15382384
]
ASF GitHub Bot commented on THRIFT-3880:
----------------------------------------
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1049
Would I be able to tell that happened from any log or history that is
public? From here it looks like the tests were re-enabled because you merged
the hash with them enabled (d150f8b). I think it is important to have a clean
and visible history so everyone knows what's going on. If in effect you simply
merged 49cefb9 by reverting the changes in d150f8b before pushing, that makes
sense.
> Erlang Compact protocol - boolean values inverted
> -------------------------------------------------
>
> Key: THRIFT-3880
> URL: https://issues.apache.org/jira/browse/THRIFT-3880
> Project: Thrift
> Issue Type: Bug
> Components: Erlang - Library
> Reporter: Vince Foley
>
> Upon using thrift's erlang compact protocol, I noticed that all of the
> boolean values are inverted.
> It turns out that the binary values used for thrift boolean values are set
> wrong, and don't match those used by other languages.
> I've prepared a PR for this issue: https://github.com/apache/thrift/pull/1049
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
