[
https://issues.apache.org/jira/browse/THRIFT-3910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15444712#comment-15444712
]
ASF GitHub Bot commented on THRIFT-3910:
----------------------------------------
GitHub user nsuke opened a pull request:
https://github.com/apache/thrift/pull/1073
THRIFT-3910 Do not invoke pip as part of build process
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nsuke/thrift THRIFT-3910
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/1073.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1073
----
commit 41b08172207ec7cba69c4b07bac10bf69ac4496e
Author: Nobuaki Sukegawa <[email protected]>
Date: 2016-08-29T03:31:12Z
THRIFT-3910 Do not invoke pip as part of build process
----
> Do not invoke pip as part of build process
> ------------------------------------------
>
> Key: THRIFT-3910
> URL: https://issues.apache.org/jira/browse/THRIFT-3910
> Project: Thrift
> Issue Type: Improvement
> Components: Build Process, Python - Library
> Affects Versions: 0.10.0
> Reporter: Aki Sukegawa
> Assignee: Aki Sukegawa
>
> Currently, Python optional dependencies are put to requriements.txt which
> Autotool/CMake scripts invoke pip on.
> The idea was to do the same as our other language builds do: install
> dependencies (Java, Ruby, Haskell etc).
> In retrospect, each language has different convention/tooling and it's rather
> surprising or rude thing to do in Python IMO.
> Instead, we can moved them to "extras_require" in setup.py so that one can
> install via "pip install thrift[all]" if they want to.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
