[ 
https://issues.apache.org/jira/browse/THRIFT-3910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15462657#comment-15462657
 ] 

ASF GitHub Bot commented on THRIFT-3910:
----------------------------------------

Github user asfgit closed the pull request at:

    https://github.com/apache/thrift/pull/1073


> Do not invoke pip as part of build process
> ------------------------------------------
>
>                 Key: THRIFT-3910
>                 URL: https://issues.apache.org/jira/browse/THRIFT-3910
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Build Process, Python - Library
>    Affects Versions: 0.10.0
>            Reporter: Aki Sukegawa
>            Assignee: Aki Sukegawa
>
> Currently, Python optional dependencies are put to requriements.txt which 
> Autotool/CMake scripts invoke pip on.
> The idea was to do the same as our other language builds do: install 
> dependencies (Java, Ruby, Haskell etc).
> In retrospect, each language has different convention/tooling and it's rather 
> surprising or rude thing to do in Python IMO.
> Instead, we can moved them to "extras_require" in setup.py so that one can 
> install via "pip install thrift[all]" if they want to.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to