[ 
https://issues.apache.org/jira/browse/THRIFT-3507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15517445#comment-15517445
 ] 

Jens Geyer commented on THRIFT-3507:
------------------------------------

Something is conflicting here. There are two patches named 
{{0001-python-THttpClient-Add-support-for-system-proxy-sett.patch}} with 
different contents changing the same source location. The result is as one 
would expect:

{code}
$ git pull
Already up-to-date.

$ git apply ../py/THRIFT-3507-1.patch
error: patch failed: lib/py/src/transport/THttpClient.py:29
error: lib/py/src/transport/THttpClient.py: patch does not apply

$ git apply 
../py/0001-python-THttpClient-Add-support-for-system-proxy-sett.patch

$ git apply 
../py/0001-python-THttpClient-Add-support-for-system-proxy-sett-2.patch
error: patch failed: lib/py/src/transport/THttpClient.py:63
error: lib/py/src/transport/THttpClient.py: patch does not apply

$ git apply ../py/0002-Python-THttpClient-Support-proxy-authorization.patch
error: patch failed: lib/py/src/transport/THttpClient.py:93
error: lib/py/src/transport/THttpClient.py: patch does not apply
{code}

1 out of 4 Patches applied successfully, 3 failed. What do I do now? Or is that 
the intended result? 

Please advise.


> THttpClient does not use proxy from http_proxy, https_proxy environment 
> variables
> ---------------------------------------------------------------------------------
>
>                 Key: THRIFT-3507
>                 URL: https://issues.apache.org/jira/browse/THRIFT-3507
>             Project: Thrift
>          Issue Type: Bug
>          Components: Python - Library
>    Affects Versions: 0.9.3
>         Environment: Windows 7 + Cygwin x64 + Python 2.7.10
>            Reporter: Fabricio Oliveira
>            Priority: Critical
>         Attachments: 
> 0001-python-THttpClient-Add-support-for-system-proxy-sett.patch, 
> THRIFT-3507-1.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to