[ 
https://issues.apache.org/jira/browse/THRIFT-3507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15517514#comment-15517514
 ] 

Martin Wilck commented on THRIFT-3507:
--------------------------------------

THRIFT-3507-1.patch was Fabricio. Mine is a modification of it, not meant to be 
applied on top.

The two different tickets were meant for 0.9.3 and 1.0.0, respectively. Note 
that in 3798, I added the proxy-auth patch on top which I don't have here. IIRC 
it should apply for the 0.9.3 branch, too.

Other than that, it has been a while. I know the patches applied when I tried 
them in April.

Here is my patch recipe that used work cleanly:
https://github.com/mwilck/geeknote/blob/master/proxy_support.md

> THttpClient does not use proxy from http_proxy, https_proxy environment 
> variables
> ---------------------------------------------------------------------------------
>
>                 Key: THRIFT-3507
>                 URL: https://issues.apache.org/jira/browse/THRIFT-3507
>             Project: Thrift
>          Issue Type: Bug
>          Components: Python - Library
>    Affects Versions: 0.9.3
>         Environment: Windows 7 + Cygwin x64 + Python 2.7.10
>            Reporter: Fabricio Oliveira
>            Priority: Critical
>         Attachments: 
> 0001-python-THttpClient-Add-support-for-system-proxy-sett.patch, 
> THRIFT-3507-1.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to