Github user vgotra commented on the issue:
https://github.com/apache/thrift/pull/1088
@Jens-G - about your comments:
> General
>
> All code files etc. need an ASF header on top. Please have a look at the
existing code if you are unsure, what, where and how to apply.
Done in the latest commit
> using Serilog;
>
> We don't like external dependencies that much. Thrift supports about 20+
languages and dialects, each additional dependency has the potential to quickly
become a PITA. So we avoid them wherever possible.
Removed in the latest commit
> lib/netcore/src/Samples
>
> If that is the Thrift Test Suite client/server pair, that part should be
move to /test/netcore. All other tests should remain under /lib/netcore. In
addition to that, we have a standardized set of arguments and exit codes. I
haven't checked how close these program(s) already adhere to them, but from a
first quick glance it may not 100%.
Moved it to tutorial/netcore folder
> Compatibility I
>
> Did you test the code against at least one other language, preferably
C++, Java or C#?
Yes, I tried to do that with Python (you can check README.md for Samples in
tutorial/netcore folder). Tests completed without problems.
> Compatibility II
>
> Can at least the Thrift Test Suite .NET Core Application code be built on
Linux and/or Mac?
Without any problems - main library (Thrift for .Net Core automatically
will be crossplatform)
You can build Samples for different platforms (I added 3 main platforms for
Samples) and tested them on different OS (Win/MacOs/Ubuntu)
Example:
dotnet restore
dotnet build **/*/project.json -r win10-x64
dotnet build **/*/project.json -r osx.10.11-x64
dotnet build **/*/project.json -r ubuntu.16.04-x64
> AssemblyInfo.cs
>
> Should be set up according to the existing C# code.
Done
> /lib/netcore/src/Samples/.../Calculator.cs
>
> The Tutorial code belongs under /tutorial/netcore. The code is later to
be included on the web site automagically from that folder.
Done
> Next, generated code should generally not be put into the source tree.
Part of the tutorial is to create these files from the IDL file.
It can be complex part - because this IDL should be created with new Thrift
generator (which should include functionality for .NET Core generation)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
