Github user Jens-G commented on the issue:
https://github.com/apache/thrift/pull/1088
Hi,
> > > lib/netcore/src/Samples
> > >
> > If that is the Thrift Test Suite client/server pair, that part should
be
> > move to /test/netcore. All other tests should remain under
/lib/netcore.
> > [...]
> >
> Moved it to tutorial/netcore folder
>
Yes, cool, thanks, but ... we do have something (i.e. an incarnation of the
Thrift Test suite client/server pair) to put under /test/netcore, do we?
The general idea is such:
- the /test folders house the Thrift Test suite client/server pairs
- the /tutorial folders is what later appears on the web site under
Tutorials. This is the Calculator example.
> > generated code should generally not be put into the source tree. Part
of
> > the tutorial is to create these files from the IDL file.
> >
> It can be complex part - because this IDL should be created with new
> Thrift generator (which should include functionality for .NET Core
> generation)
>
The Thrift compiler must always match the the library code nevertheless.
This is a given, doing otherwise will lead to problems, because things
change between versions. Hence the generated code comes with the implicit
assumption of being linked against the library version that matches the
Thrift compiler used. Always.
Second, creating the code from the IDL is (or should be) as simple as
$ thrift -r -gen netcore Tutorial.thrift
There is nothing complicated or complex about it, and it should not be more
complex than that.
Have fun,
JensG
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
