[
https://issues.apache.org/jira/browse/THRIFT-3507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15521775#comment-15521775
]
Aki Sukegawa edited comment on THRIFT-3507 at 9/26/16 2:02 AM:
---------------------------------------------------------------
edit: never mind.
The patch actually just delegates everything to urllib, so I expect my concern
to be already addressed.
-Reading http_proxy without reading no_proxy would result in another surprises
and inconveniences,-
was (Author: nsuke):
Reading http_proxy without reading no_proxy would result in another surprises
and inconveniences,
although better in that it can be worked around in users' code.
The real problem is that users have no way to use proxies in the current Thrift
API.
As these environment variables are only conventions, start reading them now may
not be a best solution.
> THttpClient does not use proxy from http_proxy, https_proxy environment
> variables
> ---------------------------------------------------------------------------------
>
> Key: THRIFT-3507
> URL: https://issues.apache.org/jira/browse/THRIFT-3507
> Project: Thrift
> Issue Type: Bug
> Components: Python - Library
> Affects Versions: 0.9.3
> Environment: Windows 7 + Cygwin x64 + Python 2.7.10
> Reporter: Fabricio Oliveira
> Priority: Critical
> Attachments:
> 0001-python-THttpClient-Add-support-for-system-proxy-sett.patch,
> THRIFT-3507-1.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
