[ 
https://issues.apache.org/jira/browse/THRIFT-3507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15522369#comment-15522369
 ] 

Martin Wilck edited comment on THRIFT-3507 at 9/26/16 7:51 AM:
---------------------------------------------------------------

1. 0001-python-THttpClient-Add-support-for-system-proxy-sett.patch
2. 0002-Python-THttpClient-Support-proxy-authorization.patch

I just re-checked the procedure in the above file. The patches apply on current 
master branch.

$ git clone https://github.com/apache/thrift.git
$ git branch proxy origin/master
$ git checkout proxy
$ curl 
https://issues.apache.org/jira/secure/attachment/12801233/0001-python-THttpClient-Add-support-for-system-proxy-sett.patch
 | git am
$ curl 
https://issues.apache.org/jira/secure/attachment/12801234/0002-Python-THttpClient-Support-proxy-authorization.patch
 | git am

$ git status
On branch proxy
Your branch is ahead of 'origin/master' by 2 commits.

$ git log --oneline origin/master..
d2bfd42 Python/THttpClient: Support proxy authorization
7ff06a1 python/THttpClient: Add support for system proxy settings



was (Author: mwilck):

1. 0001-python-THttpClient-Add-support-for-system-proxy-sett.patch
2. 0002-Python-THttpClient-Support-proxy-authorization.patch

I just re-checked the procedure in the above file. The patches apply on current 
master branch.

$ git clone https://github.com/apache/thrift.git
$ git branch proxy origin/master
$ git checkout proxy
$ curl 
https://issues.apache.org/jira/secure/attachment/12801233/0001-python-THttpClient-Add-support-for-system-proxy-sett.patch
 | git am
$ curl 
https://issues.apache.org/jira/secure/attachment/12801234/0002-Python-THttpClient-Support-proxy-authorization.patch
 | git am

$ git status
On branch proxy1
Your branch is ahead of 'origin/master' by 2 commits.

$ git log --oneline origin/master..
d2bfd42 Python/THttpClient: Support proxy authorization
7ff06a1 python/THttpClient: Add support for system proxy settings


> THttpClient does not use proxy from http_proxy, https_proxy environment 
> variables
> ---------------------------------------------------------------------------------
>
>                 Key: THRIFT-3507
>                 URL: https://issues.apache.org/jira/browse/THRIFT-3507
>             Project: Thrift
>          Issue Type: Bug
>          Components: Python - Library
>    Affects Versions: 0.9.3
>         Environment: Windows 7 + Cygwin x64 + Python 2.7.10
>            Reporter: Fabricio Oliveira
>            Priority: Critical
>         Attachments: 
> 0001-python-THttpClient-Add-support-for-system-proxy-sett.patch, 
> THRIFT-3507-1.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to