[ https://issues.apache.org/jira/browse/THRIFT-2527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15552980#comment-15552980 ]
ASF GitHub Bot commented on THRIFT-2527: ---------------------------------------- GitHub user bgould opened a pull request: https://github.com/apache/thrift/pull/1112 THRIFT-2527: Apache Thrift IDL Compiler code generated for Node.js should be jshint clean Added small style tweaks to generated node.js code so that it passes jshint with default options. When combined with the fix for THRIFT-3546 the node.js code should be able to pass with a configuration of: `{ "strict" : "implied", "node" : "true" }` You can merge this pull request into a Git repository by running: $ git pull https://github.com/bgould/thrift THRIFT-2527 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/thrift/pull/1112.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1112 ---- commit f19a407111b42e2b6daf75f1583a61ddb4fd6579 Author: BCG <bgo...@users.noreply.github.com> Date: 2016-10-06T01:14:18Z Style tweaks to pass jshint ---- > Apache Thrift IDL Compiler code generated for Node.js should be jshint clean > ---------------------------------------------------------------------------- > > Key: THRIFT-2527 > URL: https://issues.apache.org/jira/browse/THRIFT-2527 > Project: Thrift > Issue Type: Bug > Components: Node.js - Compiler > Affects Versions: 0.9.1 > Environment: all > Reporter: Randy Abernethy > > The Apache Thrift IDL Compiler emits Node.js code which produces numerous > JSHint warnings. -- This message was sent by Atlassian JIRA (v6.3.4#6332)