Github user nsuke commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1129#discussion_r87707817
--- Diff: lib/cpp/src/thrift/concurrency/Mutex.cpp ---
@@ -37,11 +37,10 @@ namespace concurrency {
#ifndef THRIFT_NO_CONTENTION_PROFILING
+static sig_atomic_t mutexProfilingCounter = 0;
static sig_atomic_t mutexProfilingSampleRate = 0;
--- End diff --
Are we dealing with signal here at all ?
Otherwise, changing these to int/int32_t would be a good idea.
mutexProfilingCounter can arguably be atomic if we want to avoid data race
(technically UB) in exchange for some performance penalty.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
