Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1129#discussion_r87711314
--- Diff: lib/cpp/src/thrift/concurrency/Mutex.cpp ---
@@ -37,11 +37,10 @@ namespace concurrency {
#ifndef THRIFT_NO_CONTENTION_PROFILING
+static sig_atomic_t mutexProfilingCounter = 0;
static sig_atomic_t mutexProfilingSampleRate = 0;
--- End diff --
According to the comment in the implementation file, a race on this
variable is acceptable, so I will change the type as you suggested and
re-submit.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
