[
https://issues.apache.org/jira/browse/THRIFT-3972?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James E. King, III updated THRIFT-3972:
---------------------------------------
Description:
An issue from THRIFT-3038 was split out so it could be completed.
There is a class in the project called NoStarveReadWriteMutex which is unused.
It has a unit test (RWMutexStarveTest).
helgrind identified that there is a race
I would prefer to just remove NoStarveReadWriteMutex as it is not used by the
project, however doing so would require refactoring the RWMutexStarveTest
because it ends up testing ReadWriteMutex, which is used by something in
{{contrib/fb303}}.
was:
As part of looking into THRIFT-3038 a couple of unused classes were identified,
and it was suggested we use a different ticket to track their removal:
NoStarveReadWriteMutex
RWGuard
Thrift's mission is to make cross-platform/cross-language RPC easy and not to
provide a cross-platform concurrency library, so there is no need to keep
unused concurrency related code in the project.
ReadWriteMutex is in use in one of the contributing libraries
> C++ Library NoStarveReadWriteMutex helgrind identified race
> -----------------------------------------------------------
>
> Key: THRIFT-3972
> URL: https://issues.apache.org/jira/browse/THRIFT-3972
> Project: Thrift
> Issue Type: Improvement
> Components: C++ - Library
> Affects Versions: 0.10.0
> Reporter: James E. King, III
> Assignee: James E. King, III
> Priority: Minor
>
> An issue from THRIFT-3038 was split out so it could be completed.
> There is a class in the project called NoStarveReadWriteMutex which is unused.
> It has a unit test (RWMutexStarveTest).
> helgrind identified that there is a race
> I would prefer to just remove NoStarveReadWriteMutex as it is not used by the
> project, however doing so would require refactoring the RWMutexStarveTest
> because it ends up testing ReadWriteMutex, which is used by something in
> {{contrib/fb303}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
