[
https://issues.apache.org/jira/browse/THRIFT-3972?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James E. King, III updated THRIFT-3972:
---------------------------------------
Description:
An issue from THRIFT-3038 was split out so it could be completed.
There is a class in the project called NoStarveReadWriteMutex which is unused
in the project.
It has a unit test (RWMutexStarveTest).
helgrind identified that there is a race in the handling of the volatile
boolean in this class.
I would prefer to just remove NoStarveReadWriteMutex as it is not used by the
project, however doing so would require refactoring the RWMutexStarveTest
because it ends up testing ReadWriteMutex, which is used by something in
{{contrib/fb303}}.
was:
An issue from THRIFT-3038 was split out so it could be completed.
There is a class in the project called NoStarveReadWriteMutex which is unused.
It has a unit test (RWMutexStarveTest).
helgrind identified that there is a race
I would prefer to just remove NoStarveReadWriteMutex as it is not used by the
project, however doing so would require refactoring the RWMutexStarveTest
because it ends up testing ReadWriteMutex, which is used by something in
{{contrib/fb303}}.
> C++ Library NoStarveReadWriteMutex helgrind identified race
> -----------------------------------------------------------
>
> Key: THRIFT-3972
> URL: https://issues.apache.org/jira/browse/THRIFT-3972
> Project: Thrift
> Issue Type: Improvement
> Components: C++ - Library
> Affects Versions: 0.10.0
> Reporter: James E. King, III
> Priority: Minor
>
> An issue from THRIFT-3038 was split out so it could be completed.
> There is a class in the project called NoStarveReadWriteMutex which is unused
> in the project.
> It has a unit test (RWMutexStarveTest).
> helgrind identified that there is a race in the handling of the volatile
> boolean in this class.
> I would prefer to just remove NoStarveReadWriteMutex as it is not used by the
> project, however doing so would require refactoring the RWMutexStarveTest
> because it ends up testing ReadWriteMutex, which is used by something in
> {{contrib/fb303}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
