[
https://issues.apache.org/jira/browse/THRIFT-3873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15680200#comment-15680200
]
ASF GitHub Bot commented on THRIFT-3873:
----------------------------------------
Github user hcorg commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1128#discussion_r88791632
--- Diff: compiler/cpp/src/thrift/generate/t_go_generator.cc ---
@@ -433,7 +434,11 @@ std::string t_go_generator::camelcase(const
std::string& value) const {
if (islower(value2[i + 1])) {
value2.replace(i, 2, 1, toupper(value2[i + 1]));
}
- fix_common_initialism(value2, i);
+
+ if (i > std::numeric_limits<int>().max()) {
+ throw "integer overflow in t_go_generator::camelcase, value = " +
value;
--- End diff --
looks like some indentation problem (some time ago `make format` was
helping with such issues... but it might no longer work :/ )
> Fix various compiler warnings when using VS2010
> -----------------------------------------------
>
> Key: THRIFT-3873
> URL: https://issues.apache.org/jira/browse/THRIFT-3873
> Project: Thrift
> Issue Type: Bug
> Components: C++ - Library
> Affects Versions: 0.10.0
> Environment: VS2010, Windows
> Reporter: James E. King, III
> Assignee: James E. King, III
> Priority: Trivial
>
> While verifying a defect I had to build the windows thrift C++ library and
> found a number of compiler warnings that needed to be cleaned up.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
