[ 
https://issues.apache.org/jira/browse/THRIFT-3873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15681392#comment-15681392
 ] 

ASF GitHub Bot commented on THRIFT-3873:
----------------------------------------

Github user jeking3 commented on a diff in the pull request:

    https://github.com/apache/thrift/pull/1128#discussion_r88804996
  
    --- Diff: lib/cpp/test/JSONProtoTest.cpp ---
    @@ -262,8 +262,9 @@ BOOST_AUTO_TEST_CASE(test_json_proto_8) {
       
":[\"i8\",3,1,2,3]},\"13\":{\"lst\":[\"i16\",3,1,2,3]},\"14\":{\"lst\":[\"i64"
       "\",3,1,2,3]}}";
     
    +  size_t bufSiz = strlen(json_string)*sizeof(char);
    --- End diff --
    
    Fixed in the next push.


> Fix various compiler warnings when using VS2010
> -----------------------------------------------
>
>                 Key: THRIFT-3873
>                 URL: https://issues.apache.org/jira/browse/THRIFT-3873
>             Project: Thrift
>          Issue Type: Bug
>          Components: C++ - Library
>    Affects Versions: 0.10.0
>         Environment: VS2010, Windows
>            Reporter: James E. King, III
>            Assignee: James E. King, III
>            Priority: Trivial
>
> While verifying a defect I had to build the windows thrift C++ library and 
> found a number of compiler warnings that needed to be cleaned up.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to